<html>
<head><meta charset="utf-8"><title>x.py clippy builds llvm · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm.html">x.py clippy builds llvm</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="237725951"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/x.py%20clippy%20builds%20llvm/near/237725951" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm.html#237725951">(May 06 2021 at 20:48)</a>:</h4>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span>  you have been doing some x.py changes in the recent past.<br>
Do you perhaps have an idea why <code>x.py clippy</code> builds llvm  (while <code>x.py check</code> does not) ? <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span></p>



<a name="237736476"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/x.py%20clippy%20builds%20llvm/near/237736476" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm.html#237736476">(May 06 2021 at 21:54)</a>:</h4>
<p>Uhhh x.py clippy is a giant hack so it's probably just a bug</p>



<a name="237736498"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/x.py%20clippy%20builds%20llvm/near/237736498" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm.html#237736498">(May 06 2021 at 21:54)</a>:</h4>
<p>But you can make it less annoying by setting download-ci-llvm to true</p>



<a name="237736631"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/x.py%20clippy%20builds%20llvm/near/237736631" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm.html#237736631">(May 06 2021 at 21:55)</a>:</h4>
<p>I'd take PRs for making it less of a hack but I don't plan to work on it myself (and by a hack I mean it uses the host toolchain instead of stage0 or the in-tree version)</p>



<a name="237736635"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/x.py%20clippy%20builds%20llvm/near/237736635" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm.html#237736635">(May 06 2021 at 21:55)</a>:</h4>
<p>missing here <a href="https://github.com/Mark-Simulacrum/rust/blob/cb3a6691b559741596baf858174ce96c0551532e/src/bootstrap/compile.rs#L663-L666">https://github.com/Mark-Simulacrum/rust/blob/cb3a6691b559741596baf858174ce96c0551532e/src/bootstrap/compile.rs#L663-L666</a></p>



<a name="237736758"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/x.py%20clippy%20builds%20llvm/near/237736758" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm.html#237736758">(May 06 2021 at 21:56)</a>:</h4>
<p>and maybe a few more places, grep for Kind::Check, probably wants to also check for Kind::Clippy, may need to be extracted to a helper function</p>



<a name="237736782"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/x.py%20clippy%20builds%20llvm/near/237736782" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm.html#237736782">(May 06 2021 at 21:56)</a>:</h4>
<p>likewise Kind::Fix probably wants the same treatment</p>



<a name="237739193"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/x.py%20clippy%20builds%20llvm/near/237739193" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm.html#237739193">(May 06 2021 at 22:16)</a>:</h4>
<p><span class="user-mention" data-user-id="217864">@matthiaskrgr</span> can you open an issue so this doesn't get forgotten?</p>



<a name="237869990"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/x.py%20clippy%20builds%20llvm/near/237869990" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm.html#237869990">(May 07 2021 at 18:34)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/85047">https://github.com/rust-lang/rust/issues/85047</a></p>



<a name="237880565"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/x.py%20clippy%20builds%20llvm/near/237880565" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm.html#237880565">(May 07 2021 at 19:50)</a>:</h4>
<p>latest nightly clippy is not compatible with the current rustc master ... :/  (build errors)</p>



<a name="237880709"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/x.py%20clippy%20builds%20llvm/near/237880709" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matthiaskrgr <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm.html#237880709">(May 07 2021 at 19:50)</a>:</h4>
<p>I also realized I might have switched to the master toolchain for x.py clippy to use a master clippy, but I still don't understand then why that would cause llvm to be rebuilt or relinked</p>



<a name="237881458"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/x.py%20clippy%20builds%20llvm/near/237881458" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm.html#237881458">(May 07 2021 at 19:56)</a>:</h4>
<p><span class="user-mention silent" data-user-id="217864">matthiaskrgr</span> <a href="#narrow/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm/near/237880565">said</a>:</p>
<blockquote>
<p>latest nightly clippy is not compatible with the current rustc master ... :/  (build errors)</p>
</blockquote>
<p>(this is <a href="#narrow/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm/near/237736631">https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/x.2Epy.20clippy.20builds.20llvm/near/237736631</a>)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>